From: Artem Bityutskiy <dedekind@infradead.org>
To: Ricard Wanderlof <ricard.wanderlof@axis.com>
Cc: Linux mtd <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] [MTD] [CORE]: Fix MEMGETOOBSEL and ECCGETLAYOUT ioctls
Date: Tue, 17 Oct 2006 18:45:11 +0300 [thread overview]
Message-ID: <1161099911.3260.97.camel@sauron> (raw)
In-Reply-To: <Pine.LNX.4.64.0610171720200.25906@lnxricardw.se.axis.com>
Ricard,
On Tue, 2006-10-17 at 17:27 +0200, Ricard Wanderlof wrote:
> Hi,
>
> This is my first patch submission, so please correct me if I've done
> anything stupid or just plain wrong. :-)
>
>
> 1. The ECCGETLAYOUT ioctl copy_to_user() call has a superfluous '&'
> causing the resulting information to be garbage rather than the intended
> mtd->ecclayout.
>
> 2. The MEMGETOOBSEL misses copying mtd->ecclayout->eccbytes so the
> resulting field of the returned structure contains garbage.
the patch looks OK, but it does not apply to the mtd git kernel. Will
you mind to send a patch against mtd-2.6.git please?
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2006-10-17 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-17 15:27 [PATCH] [MTD] [CORE]: Fix MEMGETOOBSEL and ECCGETLAYOUT ioctls Ricard Wanderlof
2006-10-17 15:45 ` Artem Bityutskiy [this message]
2006-10-18 7:01 ` Ricard Wanderlof
2006-10-18 9:04 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161099911.3260.97.camel@sauron \
--to=dedekind@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=ricard.wanderlof@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox