patch to leave cfi in read-array on suspend(reposted)

patch to leave cfi in read-array on suspend(reposted)

[David Anders]

[-- Attachment #1: Type: text/plain, Size: 674 bytes --]

greetings,

during some testing with several samsung s3c24xx based
devices it was discovered that often the
cfi_cmdset_0001.c would not leave the chip in
read-array mode on suspend. this is an issue if the
same flash chip is used for the bootloader that needs
to be read on resume. attached is a patch generated
against the 2.6.18 kernel and has been tested with
several s3c24xx based devices as well as several sharp
lh79520 devices. your feedback would be appreciated.

Signed-off-by: David Anders <danders@amltd.com>

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

[-- Attachment #2: 3238585821-cfi_cmdset_0001.patch --]
[-- Type: application/octet-stream, Size: 524 bytes --]

--- linux-2.6.18/drivers/mtd/chips/cfi_cmdset_0001.c	2006-09-19 23:42:06.000000000 -0400
+++ linux-2.6.18-m5900/drivers/mtd/chips/cfi_cmdset_0001.c	2006-09-22 09:16:21.000000000 -0400
@@ -2224,6 +2224,8 @@
 		case FL_CFI_QUERY:
 		case FL_JEDEC_QUERY:
 			if (chip->oldstate == FL_READY) {
+				/* place the chip in a known state before suspend */
+				map_write(map, CMD(0xFF), cfi->chips[i].start);
 				chip->oldstate = chip->state;
 				chip->state = FL_PM_SUSPENDED;
 				/* No need to wake_up() on this state change -

Re: patch to leave cfi in read-array on suspend(reposted)

[Nicolas Pitre]

On Thu, 19 Oct 2006, David Anders wrote:

> greetings,
> 
> during some testing with several samsung s3c24xx based
> devices it was discovered that often the
> cfi_cmdset_0001.c would not leave the chip in
> read-array mode on suspend. this is an issue if the
> same flash chip is used for the bootloader that needs
> to be read on resume. attached is a patch generated
> against the 2.6.18 kernel and has been tested with
> several s3c24xx based devices as well as several sharp
> lh79520 devices. your feedback would be appreciated.
> 
> Signed-off-by: David Anders <danders@amltd.com>

Signed-off-by: Nicolas Pitre <nico@cam.org>

Re: patch to leave cfi in read-array on suspend(reposted)

[Artem Bityutskiy]

On Thu, 2006-10-19 at 10:21 -0400, Nicolas Pitre wrote:
> > during some testing with several samsung s3c24xx based
> > devices it was discovered that often the
> > cfi_cmdset_0001.c would not leave the chip in
> > read-array mode on suspend. this is an issue if the
> > same flash chip is used for the bootloader that needs
> > to be read on resume. attached is a patch generated
> > against the 2.6.18 kernel and has been tested with
> > several s3c24xx based devices as well as several sharp
> > lh79520 devices. your feedback would be appreciated.
> > 
> > Signed-off-by: David Anders <danders@amltd.com>
> 
> Signed-off-by: Nicolas Pitre <nico@cam.org>

Thanks,

will add it to my git tree and take care about its destiny.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)