From: Artem Bityutskiy <dedekind@infradead.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: akpm <akpm@osdl.org>, dwmw2@infradead.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] MTD: fix printk format warning
Date: Tue, 24 Oct 2006 12:24:10 +0300 [thread overview]
Message-ID: <1161681850.3260.167.camel@sauron> (raw)
In-Reply-To: <20061023214826.d54fc7c6.randy.dunlap@oracle.com>
On Mon, 2006-10-23 at 21:48 -0700, Randy Dunlap wrote:
> (may be a gcc phenomenon)
> Fix printk format warning:
> drivers/mtd/maps/physmap.c:93: warning: long long unsigned int format, long unsigned int arg (arg 2)
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
... snip ...
> printk(KERN_NOTICE "physmap platform flash device: %.8llx at %.8llx\n",
> - (unsigned long long)dev->resource->end - dev->resource->start + 1,
> + (unsigned long long)(dev->resource->end - dev->resource->start + 1),
> (unsigned long long)dev->resource->start);
Hmm, AFAIK
"(unsigned long) dev->resource->end - dev->resource->start + 1" should
end up with unsigned long, so why not to fix gcc instead?
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2006-10-24 9:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-24 4:48 [PATCH] MTD: fix printk format warning Randy Dunlap
2006-10-24 9:24 ` Artem Bityutskiy [this message]
2006-10-24 10:02 ` Ben Dooks
2006-10-24 15:29 ` Randy.Dunlap
2006-10-24 16:57 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161681850.3260.167.camel@sauron \
--to=dedekind@infradead.org \
--cc=akpm@osdl.org \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox