From: Artem Bityutskiy <dedekind@infradead.org>
To: Vitaly Wool <vwool@ru.mvista.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH/RFC] remove len/ooblen confusion in MTD/NAND code
Date: Wed, 01 Nov 2006 16:41:02 +0200 [thread overview]
Message-ID: <1162392062.7527.11.camel@sauron> (raw)
In-Reply-To: <20061030145105.84f953e7.vwool@ru.mvista.com>
Hello Vitaly,
the patch looks logical for me, please find my comments below.
1. You did not change comments above the 'struct mtd_oob_ops' structure
declaration.
On Mon, 2006-10-30 at 14:51 +0300, Vitaly Wool wrote:
> if (devops.datbuf)
> devops.datbuf += devops.retlen;
> if (devops.oobbuf)
> - devops.oobbuf += devops.ooblen;
> + devops.oobbuf += subdev->oobsize;
Is this is an independent bug-fix?
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2006-11-01 14:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-30 11:51 [PATCH/RFC] remove len/ooblen confusion in MTD/NAND code Vitaly Wool
2006-10-31 11:58 ` Ricard Wanderlof
2006-11-01 13:59 ` Artem Bityutskiy
2006-11-01 14:41 ` Artem Bityutskiy [this message]
2006-11-02 7:02 ` Vitaly Wool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1162392062.7527.11.camel@sauron \
--to=dedekind@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=vwool@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox