* [PATCH] UBI: fix errorhandling in ioctl
@ 2006-12-18 12:57 Alexander Schmidt
2006-12-18 14:16 ` Artem Bityutskiy
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Schmidt @ 2006-12-18 12:57 UTC (permalink / raw)
To: Artem, ; +Cc: linux-mtd@lists.infradead.org,
Hi,
the double declaration of "int err" makes the ioctl() for resizing volumes
always return 0, even if errors occured during the resizing procedure.
I hope the patch applies this time, i double checked it...
Kind regards,
Alexander Schmidt
Signed-off-by: Alexander Schmidt, <alexs@linux.vnet.ibm.com>
---
diff --git a/drivers/mtd/ubi/cdev.c b/drivers/mtd/ubi/cdev.c
index 469cc47..be304dc 100644
--- a/drivers/mtd/ubi/cdev.c
+++ b/drivers/mtd/ubi/cdev.c
@@ -824,7 +824,7 @@ out_free:
/* Re-size volume command */
case UBI_IOCRSVOL:
{
- int err, rem, pebs;
+ int rem, pebs;
uint64_t tmp;
const struct ubi_vtbl_vtr *vtr;
struct ubi_rsvol_req req;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] UBI: fix errorhandling in ioctl
2006-12-18 12:57 [PATCH] UBI: fix errorhandling in ioctl Alexander Schmidt
@ 2006-12-18 14:16 ` Artem Bityutskiy
0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2006-12-18 14:16 UTC (permalink / raw)
To: Alexander Schmidt; +Cc: linux-mtd@lists.infradead.org,
Hello Alexander,
On Mon, 2006-12-18 at 13:57 +0100, Alexander Schmidt wrote:
> the double declaration of "int err" makes the ioctl() for resizing volumes
> always return 0, even if errors occured during the resizing procedure.
>
Thanks.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-12-18 14:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-18 12:57 [PATCH] UBI: fix errorhandling in ioctl Alexander Schmidt
2006-12-18 14:16 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox