public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind@infradead.org>
To: kyungmin.park@samsung.com
Cc: Vitaly Wool <vwool@ru.mvista.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Timo Teras <timo.teras@solidboot.com>
Subject: Re: OneNAND: Update OOB free table
Date: Thu, 21 Dec 2006 14:35:35 +0200	[thread overview]
Message-ID: <1166704535.3939.45.camel@sauron> (raw)
In-Reply-To: <1166699703.3939.37.camel@sauron>

On Thu, 2006-12-21 at 13:15 +0200, Artem Bityutskiy wrote:
> Hello,
> 
> On Mon, 2006-12-18 at 04:24 +0000, Kyungmin Park wrote:
> > How about the this patch?
> > It skips the ecc position which is defined in ecc layout in mtd drivers.
> 
> Here is my understanding of the problem.
> 
> Nowadays MTD supports nicer interface to work with OOB. This is the
> MTD_OOB_AUTO command. Currently JFFS2 uses old MTD_OOB_PLACE command.
> 
> The idea behind the MTD_OOB_AUTO command is that user provides buffer
> with his data, and MTD takes care about how to put it to the OOB area,
> MTD knows which OOB bytes may be used. Similar for reading OOB - MTD
> automatically reads data bytes, skips ECC, and returns the data.
> 
> So what we should do is to teach JFFS2 using MTD_OOB_AUTO instead of
> MTD_OOB_PLACE.

I may try to do this, but only in 2007. Vitaly said he may also try to
do this later.

Also, dwmw2 is concerned about compatibility, so we should explore this
too.

Kyungmin, may you make sure OneNAND is OK WRT MTD_OOB_AUTO?

Also Kyungmin, in you driver I see touch_softlockup_watchdog() calls. I
believe they should not be there. You must be hid a problem with this
instead of fixing it. Please, look at that stuff.

Kyungmin, do you have your own OneNAND git tree? If yes, what's the URL?
How about putting it on infradead.org, just like we have our UBI git
there?

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

  reply	other threads:[~2006-12-21 12:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-18  4:24 OneNAND: Update OOB free table Kyungmin Park
2006-12-18 14:23 ` Artem Bityutskiy
2006-12-21 11:15 ` Artem Bityutskiy
2006-12-21 12:35   ` Artem Bityutskiy [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-12-26  7:15 Kyungmin Park
2006-12-22  1:52 Kyungmin Park
2006-12-22  9:17 ` Artem Bityutskiy
2006-12-15  2:38 Kyungmin Park
2006-12-15  8:33 ` Timo Teras
2006-12-15 10:41 ` Artem Bityutskiy
2006-12-15 11:19   ` Timo Teras
2006-12-08  0:11 Kyungmin Park
2006-12-08  8:43 ` Timo Teras
2006-12-11 12:20 ` Timo Teras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1166704535.3939.45.camel@sauron \
    --to=dedekind@infradead.org \
    --cc=dwmw2@infradead.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=timo.teras@solidboot.com \
    --cc=vwool@ru.mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox