From: Artem Bityutskiy <dedekind@infradead.org>
To: Vijay Kumar <vijaykumar@bravegnu.org>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] NAND: nandsim bad block injection
Date: Thu, 28 Dec 2006 12:22:21 +0200 [thread overview]
Message-ID: <1167301341.4217.30.camel@sauron> (raw)
In-Reply-To: <17810.36897.44930.853654@vaishnavi.localdomain>
Vijay,
On Wed, 2006-12-27 at 20:54 +0530, Vijay Kumar wrote:
> Adds support for bad block creation on block erase and page program,
> by returning erase/program failed in the status byte. The probability
> of fault occurrence can be specified through module parameters.
the patch looks fine, and it is useful for debugging. But I have few
concerns.
1. Suppose we decided to emulate an erase failure for a certain
eraseblock. Then the MTD user re-tries the operation and succeeds.
Shouldn't we start always returning erase errors for this eraseblock
instead?
2. In case of I/O errors, the correct MTD user should mark the bogus
eraseblock bad. So, after some time we end up with most of our
eraseblocks marked bad which is not very nice.
How would you comment this?
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2006-12-28 10:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-27 15:24 [PATCH] NAND: nandsim bad block injection Vijay Kumar
2006-12-28 10:22 ` Artem Bityutskiy [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-12-24 13:08 Vijay Kumar
2006-12-27 11:26 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1167301341.4217.30.camel@sauron \
--to=dedekind@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=vijaykumar@bravegnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox