public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind@infradead.org>
To: Alexander Schmidt <alexs@linux.vnet.ibm.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [MTD] UBI: Per volume update marker
Date: Tue, 30 Jan 2007 17:36:10 +0200	[thread overview]
Message-ID: <1170171370.9477.150.camel@sauron> (raw)
In-Reply-To: <200701291736.01006.alexs@linux.vnet.ibm.com>

One more comment. Yo add a 'ubi_vtbl_updvol()' function which can only
change the update marker. But lets consider what you really need:

* set update marker
* clean update marker, set data length field (static-only, RAM-only),
clear the 'corrupted' flag (static-only, RAM-only).

Currently there is a 'ubi_vtbl_set_data_len()' function which sets data
length and clears the corrupted flag.

So I recommend:

* add a 'ubi_vtbl_set_upd_marker()' func - it can only set the
upd_marker flag.
* add a 'ubi_vtbl_clear_upd_marker()' func - it cleans the update
marker, set data length, and clears 'corrupted' flag.

And the 'UBI_VOL_UPD' and 'UBI_VOL_NOUPD' constant are not really
reasonable I guess - indeed, we have just a boolean flag - these
constants are overkill.

Thanks.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

  parent reply	other threads:[~2007-01-30 16:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-24  9:19 [MTD] UBI: Per volume update marker Alexander Schmidt
2007-01-25 18:16 ` Artem Bityutskiy
2007-01-25 19:19   ` Josh Boyer
2007-01-26  8:47   ` Frank Haverkamp
2007-01-26 10:43     ` Artem Bityutskiy
2007-01-26  8:04 ` Artem Bityutskiy
2007-01-29 10:47   ` Alexander Schmidt
2007-01-29 13:02     ` Artem Bityutskiy
2007-01-29 16:36       ` Alexander Schmidt
2007-01-30 13:01         ` Artem Bityutskiy
2007-01-30 13:44         ` Artem Bityutskiy
2007-01-30 15:36         ` Artem Bityutskiy [this message]
2007-01-30 18:35         ` Artem Bityutskiy
2007-01-30 19:00         ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1170171370.9477.150.camel@sauron \
    --to=dedekind@infradead.org \
    --cc=alexs@linux.vnet.ibm.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox