From: Artem Bityutskiy <dedekind@infradead.org>
To: Thomas Koeller <thomas.koeller@baslerweb.com>
Cc: linux-mips@linux-mips.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] eXcite nand flash driver
Date: Thu, 08 Feb 2007 15:55:40 +0200 [thread overview]
Message-ID: <1170942940.7984.5.camel@sauron> (raw)
In-Reply-To: <1170942627.4884.89.camel@zod.rchland.ibm.com>
On Thu, 2007-02-08 at 07:50 -0600, Josh Boyer wrote:
> > + /* free the common resources */
> > + if (likely(this->regs)) {
> > + iounmap(this->regs);
> > + this->regs = NULL;
> > + }
>
> Same likely usage comment as above.
I agree, this function will be called one or very few times, so this
hint is not reasonable in this case.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2007-02-08 14:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-08 0:57 [PATCH] eXcite nand flash driver Thomas Koeller
2007-02-08 13:50 ` Josh Boyer
2007-02-08 13:55 ` Artem Bityutskiy [this message]
2007-02-08 15:48 ` Thomas Gleixner
2007-02-10 10:22 ` Thomas Koeller
2007-02-11 15:44 ` Thomas Gleixner
-- strict thread matches above, loose matches on Subject: below --
2007-02-10 10:21 Thomas Koeller
2007-02-11 15:50 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1170942940.7984.5.camel@sauron \
--to=dedekind@infradead.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
--cc=thomas.koeller@baslerweb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox