From: Artem Bityutskiy <dedekind@infradead.org>
To: Timo Lindhorst <lindhors@linux.vnet.ibm.com>
Cc: MTD list <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] [MTD] UBI: Fix counting of ec value
Date: Mon, 12 Feb 2007 13:38:10 +0200 [thread overview]
Message-ID: <1171280290.17314.23.camel@sauron> (raw)
In-Reply-To: <45D045FC.7090902@linux.vnet.ibm.com>
On Mon, 2007-02-12 at 11:48 +0100, Timo Lindhorst wrote:
> > So why have you moved this memory allocation here?
> Actually I have not moved up the allocation, but moved down the
> 'if (unlikely(ec > UBI_MAX_ERASECOUNTER)) { ... ' block, since we need
> to know the new ec value before we can do this test.
OK, fine, just free the memory there.
> > What's the point in the new 'ret' variable? Why ec += err does not work?
> I just thought adding an error code to a counter seems odd. Do you
> prefer this way?
Well, it's anyway better then a distinct variable IMO. Moreover, it is
used like this across the UBI code, so just assume it is UBI style :-)
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
prev parent reply other threads:[~2007-02-12 11:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-12 9:16 [PATCH] [MTD] UBI: Fix counting of ec value Timo Lindhorst
2007-02-12 9:52 ` Artem Bityutskiy
2007-02-12 10:48 ` Timo Lindhorst
2007-02-12 11:38 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1171280290.17314.23.camel@sauron \
--to=dedekind@infradead.org \
--cc=lindhors@linux.vnet.ibm.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox