* [PATCH] JFFS2: Fix writebuffer recovery in the first page of a block
@ 2007-02-26 16:09 Thomas Gleixner
0 siblings, 0 replies; only message in thread
From: Thomas Gleixner @ 2007-02-26 16:09 UTC (permalink / raw)
To: 'linux-mtd'; +Cc: dwmw2
From: Vitaly Wool <vwool@ru.mvista.com>
For the case when nand_write_page fail with -EIO for the first page in an
eraseblock, jffs2_wbuf_recover ends up producing a BUG in jffs2_block_refile
as jeb->first_node is not yet set up (it's set up later in jffs2_wbuf_recover).
This BUG is not really a bug; it's just jffs2_wbuf_recover calling
jffs2_block_refile with the wrong second parameter.
This patch takes care of this situation.
fs/jffs2/wbuf.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletion(-)
Signed-off-by: Vitaly Wool <vwool@ru.mvista.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Index: linux-2.6/fs/jffs2/wbuf.c
===================================================================
--- linux-2.6.orig/fs/jffs2/wbuf.c 2006-11-28 17:08:25.000000000 +0300
+++ linux-2.6/fs/jffs2/wbuf.c 2007-02-26 18:29:58.000000000 +0300
@@ -237,7 +237,10 @@
jeb = &c->blocks[c->wbuf_ofs / c->sector_size];
spin_lock(&c->erase_completion_lock);
- jffs2_block_refile(c, jeb, REFILE_NOTEMPTY);
+ if (c->wbuf_ofs % c->mtd->erasesize)
+ jffs2_block_refile(c, jeb, REFILE_NOTEMPTY);
+ else
+ jffs2_block_refile(c, jeb, REFILE_ANYWAY);
spin_unlock(&c->erase_completion_lock);
BUG_ON(!ref_obsolete(jeb->last_node));
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-02-26 16:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-26 16:09 [PATCH] JFFS2: Fix writebuffer recovery in the first page of a block Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox