public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] [MTD] UBI: fix background thread define
@ 2007-02-27 13:34 Alexander Schmidt
  2007-02-27 14:09 ` Artem Bityutskiy
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Schmidt @ 2007-02-27 13:34 UTC (permalink / raw)
  To: Artem; +Cc: linux-mtd@lists.infradead.org

Hi Artem,

This patch renames DBG_ENABLE_BGT to DBG_DISABLE_BGT, which makes it more
obvious that the background thread should be enabled by default. The name
corresponds to the kernel config option now.

I also fixed the semantics on intialisation (bgt now gets enabled when
DBG_DISABLE_BGT == 0), and compilation with debugging disabled works again.

Signed-off-by: Alexander Schmidt <alexs@linux.vnet.ibm.com>
---
 drivers/mtd/ubi/build.c |    2 +-
 drivers/mtd/ubi/debug.h |    6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)

--- dedekind-ubi-2.6.orig/drivers/mtd/ubi/build.c
+++ dedekind-ubi-2.6/drivers/mtd/ubi/build.c
@@ -266,7 +266,7 @@ static int attach_mtd_dev(const char *mt
 	ubi_msg("number of PEBs reserved for bad PEB handling: %d",
 		ubi->beb.reserved_pebs);
 
-	if (!DBG_ENABLE_BGT && !ubi->io.ro_mode)
+	if (!DBG_DISABLE_BGT && !ubi->io.ro_mode)
 		ubi_bgt_enable(ubi);
 
 	return 0;
--- dedekind-ubi-2.6.orig/drivers/mtd/ubi/debug.h
+++ dedekind-ubi-2.6/drivers/mtd/ubi/debug.h
@@ -30,9 +30,9 @@
 #ifdef CONFIG_MTD_UBI_DEBUG
 
 #ifdef CONFIG_MTD_UBI_DEBUG_DISABLE_BGT
-#define DBG_ENABLE_BGT 0
+#define DBG_DISABLE_BGT 1
 #else
-#define DBG_ENABLE_BGT 1
+#define DBG_DISABLE_BGT 0
 #endif
 #define UBI_DEBUG 1
 
@@ -142,6 +142,8 @@ void __exit ubi_dbg_close(void);
 
 #define UBI_DEBUG 0
 
+#define DBG_DISABLE_BGT 0
+
 #define ubi_assert(expr)    ({})
 
 #define dbg_err(fmt, ...)    ({})

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] [MTD] UBI: fix background thread define
  2007-02-27 13:34 [PATCH] [MTD] UBI: fix background thread define Alexander Schmidt
@ 2007-02-27 14:09 ` Artem Bityutskiy
  0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2007-02-27 14:09 UTC (permalink / raw)
  To: Alexander Schmidt; +Cc: linux-mtd@lists.infradead.org

On Tue, 2007-02-27 at 14:34 +0100, Alexander Schmidt wrote:
> This patch renames DBG_ENABLE_BGT to DBG_DISABLE_BGT, which makes it more
> obvious that the background thread should be enabled by default. The name
> corresponds to the kernel config option now.

Hi, applied, thanks.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-02-27 14:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-27 13:34 [PATCH] [MTD] UBI: fix background thread define Alexander Schmidt
2007-02-27 14:09 ` Artem Bityutskiy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox