From: David Woodhouse <dwmw2@infradead.org>
To: joakim.tjernlund@transmode.se
Cc: linux-mtd@lists.infradead.org
Subject: Re: JFFS2 OOPS in 2.6.20
Date: Fri, 09 Mar 2007 11:08:35 +0000 [thread overview]
Message-ID: <1173438515.3461.582.camel@pmac.infradead.org> (raw)
In-Reply-To: <1173437173.26465.37.camel@gentoo-jocke.transmode.se>
On Fri, 2007-03-09 at 11:46 +0100, Joakim Tjernlund wrote:
> Tested your patch and now it boots again with this :)
> JFFS2 error: (137) read_unknown: REF_UNCHECKED but unknown node at 0x3aa28fc
> JFFS2 error: (137) read_unknown: Node is {0000,0000,00000000,00000000}. Please report this error.
Stupid dwmw2. No biscuit.
diff -u b/fs/jffs2/readinode.c b/fs/jffs2/readinode.c
--- b/fs/jffs2/readinode.c
+++ b/fs/jffs2/readinode.c
@@ -585,7 +585,7 @@
}
/* Due to poor choice of crc32 seed, an all-zero node will have a correct CRC */
if (!je32_to_cpu(node->u.hdr_crc) && !je16_to_cpu(node->u.nodetype) &&
- !je16_to_cpu(node->u.magic) && je32_to_cpu(node->u.totlen)) {
+ !je16_to_cpu(node->u.magic) && !je32_to_cpu(node->u.totlen)) {
JFFS2_NOTICE("All zero node header at %#08x.\n", ref_offset(ref));
jffs2_mark_node_obsolete(c, ref);
goto cont;
diff -u b/fs/jffs2/scan.c b/fs/jffs2/scan.c
--- b/fs/jffs2/scan.c
+++ b/fs/jffs2/scan.c
@@ -736,7 +736,7 @@
}
/* Due to poor choice of crc32 seed, an all-zero node will have a correct CRC */
if (!je32_to_cpu(node->hdr_crc) && !je16_to_cpu(node->nodetype) &&
- !je16_to_cpu(node->magic) && je32_to_cpu(node->totlen)) {
+ !je16_to_cpu(node->magic) && !je32_to_cpu(node->totlen)) {
noisy_printk(&noise, "jffs2_scan_eraseblock(): All zero node header at 0x%08x.\n", ofs);
if ((err = jffs2_scan_dirty_space(c, jeb, 4)))
--
dwmw2
next prev parent reply other threads:[~2007-03-09 11:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-08 17:14 JFFS2 OOPS in 2.6.20 Joakim Tjernlund
2007-03-08 17:33 ` Joakim Tjernlund
2007-03-08 17:44 ` Joakim Tjernlund
2007-03-08 18:37 ` David Woodhouse
2007-03-08 18:46 ` Artem Bityutskiy
2007-03-08 18:51 ` David Woodhouse
2007-03-09 9:02 ` Joakim Tjernlund
2007-03-09 9:23 ` David Woodhouse
2007-03-09 10:46 ` Joakim Tjernlund
2007-03-09 11:08 ` David Woodhouse [this message]
2007-03-09 11:15 ` Joakim Tjernlund
2007-03-09 11:24 ` David Woodhouse
2007-03-09 12:01 ` Joakim Tjernlund
2007-03-09 13:54 ` Joakim Tjernlund
2007-03-09 14:49 ` Joakim Tjernlund
2007-03-10 16:08 ` Joakim Tjernlund
2007-03-09 9:36 ` Joakim Tjernlund
2007-03-09 9:46 ` David Woodhouse
2007-03-09 10:56 ` Joakim Tjernlund
2007-03-09 13:11 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173438515.3461.582.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=joakim.tjernlund@transmode.se \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox