From: Artem Bityutskiy <dedekind@infradead.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] JFFS2: fix deadlock on error path
Date: Sat, 17 Mar 2007 12:48:50 +0200 [thread overview]
Message-ID: <1174128530.11927.13.camel@sauron> (raw)
In-Reply-To: <1173788365.5493.31.camel@sauron>
On Tue, 2007-03-13 at 14:19 +0200, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
> Subject: [PATCH] JFFS2: fix deadlock on error path
>
> When the MTD driver returns write failure, the following deadlock
> occures:
>
> We are in __jffs2_flush_wbuf(), we hold &c->wbuf_sem. Write failure.
> jffs2_wbuf_recover()->jffs2_reserve_space_gc()->jffs2_do_reserve_space()
> ->jffs2_erase_pending_blocks()->jffs2_flash_read()
>
> and it tries to lock &c->wbuf_sem again. Deadlock.
>
> Reported-by: Adrian Hunter <ext-adrian.hunter@nokia.com>
> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
David,
please, send this patch to Linus as it is critical enough.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
prev parent reply other threads:[~2007-03-17 10:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-13 12:19 [PATCH] JFFS2: fix deadlock on error path Artem Bityutskiy
2007-03-17 10:48 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1174128530.11927.13.camel@sauron \
--to=dedekind@infradead.org \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox