Linux-mtd Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: "Knobloch, Thomas" <knobloch@siemens.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: NAND bad block checking when no memory based BBT is available
Date: Thu, 26 Apr 2007 17:40:43 +0100	[thread overview]
Message-ID: <1177605643.2755.420.camel@pmac.infradead.org> (raw)
In-Reply-To: <2EDADF4ED023F04BAD4D7A4131ECEB930105514A@mchp7rfa.ww002.siemens.net>

On Thu, 2007-04-26 at 17:38 +0200, Knobloch, Thomas wrote:
>         if (getchip) {
>                 page = (int)(ofs >> chip->page_shift);
>                 chipnr = (int)(ofs >> chip->chip_shift);
> 
>                 nand_get_device(chip, mtd, FL_READING);
> 
>                 /* Select the NAND device */
>                 chip->select_chip(mtd, chipnr);
>         } else
>                 page = (int)ofs; 

I think we'll accept a patch which makes that last line also shift right
by chip->page_shift.

-- 
dwmw2

      parent reply	other threads:[~2007-04-26 16:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-26 15:38 NAND bad block checking when no memory based BBT is available Knobloch, Thomas
2007-04-26 16:31 ` David Woodhouse
2007-04-26 17:23   ` Thomas Gleixner
2007-04-26 16:40 ` David Woodhouse [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1177605643.2755.420.camel@pmac.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=knobloch@siemens.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox