Re: [PATCH] nand: add cmd_ctrl to platform_nand_chip

Re: [PATCH] nand: add cmd_ctrl to platform_nand_chip

[Thomas Gleixner]

On Mon, 2007-04-30 at 13:23 +0400, Vitaly Wool wrote:
> Hello Thomas,
> 
> please find the patch that extends struct platform_nand_chip with 
> cmd_ctrl field.

Looks good. Can you please resend with a useful changelog ?

Thanks,

	tglx

>  include/linux/mtd/nand.h |    4 ++++
>  1 files changed, 4 insertions(+)
> 
> Signed-off-by: Vitaly Wool <vitalywool@gmail.com>
> 
> Index: linux-2.6/include/linux/mtd/nand.h
> ===================================================================
> --- linux-2.6.orig/include/linux/mtd/nand.h
> +++ linux-2.6/include/linux/mtd/nand.h
> @@ -577,6 +577,8 @@ struct platform_nand_chip {
>   * @hwcontrol:		platform specific hardware control structure
>   * @dev_ready:		platform specific function to read ready/busy pin
>   * @select_chip:	platform specific chip select function
> + * @cmd_ctrl:		platform specific function for controlling
> + *			ALE/CLE/nCE. Also used to write command and address
>   * @priv:		private data to transport driver specific settings
>   *
>   * All fields are optional and depend on the hardware driver requirements
> @@ -585,6 +587,8 @@ struct platform_nand_ctrl {
>  	void		(*hwcontrol)(struct mtd_info *mtd, int cmd);
>  	int		(*dev_ready)(struct mtd_info *mtd);
>  	void		(*select_chip)(struct mtd_info *mtd, int chip);
> +	void		(*cmd_ctrl)(struct mtd_info *mtd, int dat,
> +				    unsigned int ctrl);
>  	void		*priv;
>  };
>  
>