From: Thomas Gleixner <tglx@linutronix.de>
To: "Knobloch, Thomas" <knobloch@siemens.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: AW: [PATCH] [MTD] NAND: Wrong calculation of page number innand_block_bad()
Date: Wed, 02 May 2007 17:18:14 +0200 [thread overview]
Message-ID: <1178119094.25504.1.camel@localhost.localdomain> (raw)
In-Reply-To: <2EDADF4ED023F04BAD4D7A4131ECEB93010554E3@mchp7rfa.ww002.siemens.net>
On Wed, 2007-05-02 at 14:14 +0200, Knobloch, Thomas wrote:
> On Fri, 2007-04-27 at 19:04, Thomas Gleixner wrote:
> > Can you please make this outside the else path, so we can remove same
> > code in the if (getchip) path.
> >
> > Please also apply the pagemask right there so we don't have it in both
> > cmdfunc() calls.
>
> I added the requested code cleanup to the original patch:
If you now manage to send a non line wrapped patch with the log message
and your Signed-off-by, then I can apply it right from the mail.
Thanks,
tglx
> if (chip->options & NAND_BUSWIDTH_16) {
> chip->cmdfunc(mtd, NAND_CMD_READOOB, chip->badblockpos &
> 0xFE,
> + chip->cmdfunc(mtd, NAND_CMD_READOOB, chip->badblockpos,
> page);
> if (chip->read_byte(mtd) != 0xff)
> res = 1;
> }
next prev parent reply other threads:[~2007-05-02 15:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-27 11:19 [PATCH] [MTD] NAND: Wrong calculation of page number in nand_block_bad() Knobloch, Thomas
2007-04-27 17:03 ` Thomas Gleixner
2007-05-02 12:14 ` AW: [PATCH] [MTD] NAND: Wrong calculation of page number innand_block_bad() Knobloch, Thomas
2007-05-02 15:18 ` Thomas Gleixner [this message]
2007-05-02 17:48 ` Thomas Knobloch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178119094.25504.1.camel@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=knobloch@siemens.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox