From: Thomas Gleixner <tglx@linutronix.de>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: david@woodhou.se, linux-mtd@lists.infradead.org
Subject: Re: [PATCH rslib] Support non-canonical GF representations
Date: Thu, 03 May 2007 01:18:50 +0200 [thread overview]
Message-ID: <1178147931.2340.40.camel@localhost.localdomain> (raw)
In-Reply-To: <20070502101841.B420B7F7FAB@schermpje.krocht>
On Wed, 2007-05-02 at 12:18 +0200, Segher Boessenkool wrote:
> + if (gfpoly) {
> + sr = 1;
> + for (i = 0; i < rs->nn; i++) {
> + rs->index_of[sr] = i;
> + rs->alpha_to[i] = sr;
> + sr <<= 1;
> + if (sr & (1 << symsize))
> + sr ^= gfpoly;
> + sr &= rs->nn;
> + }
> + } else {
> + sr = gffunc(0);
> + for (i = 0; i < rs->nn; i++) {
> + rs->index_of[sr] = i;
> + rs->alpha_to[i] = sr;
> + sr = gffunc(sr);
> + }
> }
Hmm, please check for
if (!gffunc)
instead of
if (gfpoly)
Please fix that up and add my
Acked-by: Thomas Gleixner <tglx@linutronix,de>
tglx
next prev parent reply other threads:[~2007-05-02 23:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-02 10:18 [PATCH rslib] Support non-canonical GF representations Segher Boessenkool
2007-05-02 23:18 ` Thomas Gleixner [this message]
2007-05-02 23:50 ` Segher Boessenkool
-- strict thread matches above, loose matches on Subject: below --
2007-05-03 0:02 Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178147931.2340.40.camel@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=david@woodhou.se \
--cc=linux-mtd@lists.infradead.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox