From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [Patch 06/18] fs/logfs/compr.c From: David Woodhouse To: =?ISO-8859-1?Q?J=F6rn?= Engel In-Reply-To: <20070604085447.GA14823@lazybastard.org> References: <20070603183845.GA8952@lazybastard.org> <20070603184355.GG8952@lazybastard.org> <200706032358.44870.arnd@arndb.de> <20070604085447.GA14823@lazybastard.org> Content-Type: text/plain; charset=UTF-8 Date: Mon, 04 Jun 2007 14:53:46 +0100 Message-Id: <1180965226.25232.361.camel@pmac.infradead.org> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: akpm@osdl.org, David Weinehall , Dongjun Shin , Kyle Moffett , linux-mtd@lists.infradead.org, Pavel Machek , Sam Ravnborg , Ulisses Furquim , CaT , Evgeniy Polyakov , Roland Dreier , Arnd Bergmann , Jamie Lokier , Pekka Enberg , Jan Engelhardt , Thomas Gleixner , Bill Davidsen , Albert Cahalan , John Stoffel , linux-kernel@vger.kernel.org, Ondrej Zajicek , linux-fsdevel@vger.kernel.org, Willy Tarreau List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2007-06-04 at 10:54 +0200, Jörn Engel wrote: > There is no particular reason. '3' should be a reasonable value for > most people. If actual users want to change this value, I can make it > a mount option as well. Right now I'm just lazy and doubt the merits. I think you probably made the right choice. If you're compressing small chunks at a time, increasing the amount of history which the compressor will keep really doesn't buy you much. -- dwmw2