From: Thomas Gleixner <tglx@linutronix.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: olof@lixom.net, linux-mtd@lists.infradead.org, c@pasemi.com,
Egor Martovetsky <egor@pasemi.com>
Subject: Re: [PATCH] [2.6.23] nand_flash_dev - add manufacturer ID
Date: Wed, 04 Jul 2007 07:55:54 +0200 [thread overview]
Message-ID: <1183528554.3291.60.camel@chaos> (raw)
In-Reply-To: <1183507424.29081.73.camel@shinybook.infradead.org>
On Tue, 2007-07-03 at 20:03 -0400, David Woodhouse wrote:
> The difference between LP_OPTIONS and the options you've set for the new
> chip is just NAND_NO_PADDING | NAND_COPYBACK, right? Neither of which we
> actually use right now _anyway_.
>
> I wonder if we should do this differently, and mask certain features in
> or out according to the manufacturer, after identifying the chip.
We do that already:
/* Check if chip is a not a samsung device. Do not clear the
* options for chips which are not having an extended id.
*/
if (*maf_id != NAND_MFR_SAMSUNG && !type->pagesize)
chip->options &= ~NAND_SAMSUNG_LP_OPTIONS;
So we should do this for that one as well.
tglx
next prev parent reply other threads:[~2007-07-04 5:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-03 23:54 [PATCH] [2.6.23] nand_flash_dev - add manufacturer ID Egor Martovetsky
2007-07-04 0:03 ` David Woodhouse
2007-07-04 5:55 ` Thomas Gleixner [this message]
2007-07-05 17:44 ` Egor N. Martovetsky
2007-07-05 18:03 ` David Woodhouse
2007-07-05 18:55 ` Egor N. Martovetsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1183528554.3291.60.camel@chaos \
--to=tglx@linutronix.de \
--cc=c@pasemi.com \
--cc=dwmw2@infradead.org \
--cc=egor@pasemi.com \
--cc=linux-mtd@lists.infradead.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox