From: David Woodhouse <dwmw2@infradead.org>
To: WANG Cong <xiyou.wangcong@gmail.com>
Cc: kirk@hpc.ee.ntu.edu.tw, akpm@osdl.org,
LKML <linux-kernel@vger.kernel.org>,
linux-mtd@lists.infradead.org
Subject: Re: [Resend][Patch] drivers/mtd/maps/tqm8xxl.c: Do some cleanups
Date: Fri, 13 Jul 2007 10:56:42 +0100 [thread overview]
Message-ID: <1184320602.2785.18.camel@shinybook.infradead.org> (raw)
In-Reply-To: <20070713034822.GA2370@localhost.localdomain>
On Fri, 2007-07-13 at 11:48 +0800, WANG Cong wrote:
> if(map_banks[idx] == NULL) {
> ret = -ENOMEM;
> - /* FIXME: What if some MTD devices were probed already? */
> + /* FIXME: What if some MTD devices were probed
> + already? */
> goto error_mem;
> }
That's just horrid. Leave it as it was.
--
dwmw2
next prev parent reply other threads:[~2007-07-13 9:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-12 15:01 [Patch] drivers/mtd/maps/tqm8xxl.c: Style cleanups WANG Cong
2007-07-12 16:11 ` Josh Boyer
[not found] ` <20070713034822.GA2370@localhost.localdomain>
2007-07-13 9:56 ` David Woodhouse [this message]
2007-07-13 13:14 ` [Resend][Patch] drivers/mtd/maps/tqm8xxl.c: Do some cleanups WANG Cong
2007-07-13 13:38 ` David Woodhouse
2007-07-13 14:24 ` Ralf Baechle
2007-07-13 14:31 ` David Woodhouse
2007-07-13 15:11 ` WANG Cong
2007-07-13 15:05 ` WANG Cong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184320602.2785.18.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=akpm@osdl.org \
--cc=kirk@hpc.ee.ntu.edu.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox