linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Cc: linux-mtd@lists.infradead.org, ye janboe <janboe.ye@gmail.com>
Subject: Re: JFFS2 deadlock with alloc_sem
Date: Mon, 30 Jul 2007 13:45:08 +0100	[thread overview]
Message-ID: <1185799508.3083.20.camel@pmac.infradead.org> (raw)
In-Reply-To: <1185557896.22352.4.camel@kleikamp.austin.ibm.com>

On Fri, 2007-07-27 at 12:38 -0500, Dave Kleikamp wrote:
> I could only speculate, since I really don't know the code.  I suspect
> the writer of the comment had some other deadlock scenario in mind and
> didn't foresee the one that was encountered. 

I'm still confused because we deliberately ensure the page is up to date
in prepare_write -- so read_cache_page() should never have to lock it,
and we should never deadlock.

Or did I miss something in your analysis (or elsewhere)?

Why is read_cache_page() ever trying to lock this page in the first
place? It should be up to date.

-- 
dwmw2

  reply	other threads:[~2007-07-30 12:45 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <af3ea28a0707262032h7ee22775t6ef54e364a9cd704@mail.gmail.com>
2007-07-27  3:38 ` JFFS2 deadlock with alloc_sem ye janboe
2007-07-27 13:42   ` Dave Kleikamp
2007-07-27 16:35     ` ye janboe
2007-07-27 17:38       ` Dave Kleikamp
2007-07-30 12:45         ` David Woodhouse [this message]
2007-07-30 16:45           ` Dave Kleikamp
2007-07-31 12:10             ` David Woodhouse
2007-07-31 12:40               ` David Woodhouse
2007-07-31 13:23               ` Dave Kleikamp
2007-07-31 15:23                 ` David Woodhouse
2007-07-31 15:36                   ` Dave Kleikamp
2007-07-31 16:23                     ` David Woodhouse
2007-08-02  4:11                       ` ye janboe
2007-06-08 19:26 Dave Kleikamp
2007-06-11 12:14 ` David Woodhouse
2007-06-12  1:45   ` Roberts Nathan-mcg31137
2007-06-19 16:11     ` Dave Kleikamp
2007-06-19 19:42       ` Dave Kleikamp
  -- strict thread matches above, loose matches on Subject: below --
2007-04-30 19:41 Roberts Nathan-mcg31137
2007-05-05  8:23 ` David Woodhouse
2007-06-02 17:42 ` David Woodhouse
2007-06-05 14:21   ` Roberts Nathan-mcg31137
2007-06-07 14:29   ` Josh Boyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1185799508.3083.20.camel@pmac.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=janboe.ye@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=shaggy@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).