From: David Woodhouse <dwmw2@infradead.org>
To: Jared Hulbert <jaredeh@gmail.com>
Cc: dhowells <dhowells@redhat.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH][MTD] mtdpart.c: allow other drivers to get physical address of partition
Date: Tue, 31 Jul 2007 12:55:32 +0100 [thread overview]
Message-ID: <1185882932.3083.98.camel@pmac.infradead.org> (raw)
In-Reply-To: <6934efce0707261704p5e46e238i5b7ee433fc4f5bda@mail.gmail.com>
On Thu, 2007-07-26 at 17:04 -0700, Jared Hulbert wrote:
> +/*
> + * Allow other modules to get the physical address of a given partition
> + */
> +void *mtd_get_partition_physaddr(struct mtd_info *mtd)
> +{
> + struct mtd_part *part = PART(mtd);
> + struct map_info *map = part->master->priv;
> +
> + return (void *)(map->phys + part->offset);
> +}
> +EXPORT_SYMBOL_GPL(mtd_get_partition_physaddr);
The problem with this is that it expects the caller to 'know' that the
mtd device it's using is in fact a partition. If we have to do this, I'd
rather see it done generically. Jörn is probably right that it should be
available from (whatever replaces) the point() method.
--
dwmw2
next prev parent reply other threads:[~2007-07-31 11:55 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-27 0:04 [PATCH][MTD] mtdpart.c: allow other drivers to get physical address of partition Jared Hulbert
2007-07-27 13:48 ` Jörn Engel
2007-07-27 17:05 ` Jared Hulbert
2007-07-27 17:44 ` Jörn Engel
2007-07-27 20:53 ` Jared Hulbert
2007-07-28 11:43 ` Jörn Engel
2007-07-28 21:08 ` Jared Hulbert
2007-07-31 11:55 ` David Woodhouse [this message]
2007-07-31 19:55 ` Jared Hulbert
2007-08-01 11:55 ` Jörn Engel
2007-08-03 1:56 ` Jared Hulbert
2007-08-03 3:01 ` Jörn Engel
2007-08-03 5:23 ` Jared Hulbert
2007-08-03 9:21 ` Jörn Engel
2007-08-03 6:42 ` Jared Hulbert
2007-08-03 12:47 ` Jörn Engel
2007-08-03 22:29 ` Jared Hulbert
2007-08-01 12:18 ` Jörn Engel
2007-08-01 12:59 ` Carsten Otte
2007-08-01 20:37 ` Jared Hulbert
2007-08-01 23:31 ` Jörn Engel
2007-08-02 7:53 ` Carsten Otte
2007-08-02 21:55 ` Jared Hulbert
2007-08-03 7:59 ` Carsten Otte
2007-08-03 9:17 ` Jörn Engel
2007-08-03 11:03 ` Carsten Otte
2007-08-03 11:31 ` Jörn Engel
2007-08-03 12:21 ` Carsten Otte
2007-08-03 12:58 ` Jörn Engel
2007-08-03 13:09 ` David Woodhouse
2007-08-03 13:18 ` Jörn Engel
2007-08-03 19:45 ` Jared Hulbert
2007-08-03 23:02 ` Jörn Engel
2007-08-04 12:33 ` David Woodhouse
2007-08-04 17:47 ` Jared Hulbert
2007-08-06 6:30 ` Carsten Otte
2007-08-03 18:39 ` Jared Hulbert
2007-08-06 6:23 ` Carsten Otte
2007-08-01 18:03 ` Jared Hulbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185882932.3083.98.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=dhowells@redhat.com \
--cc=jaredeh@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox