From: David Woodhouse <dwmw2@infradead.org>
To: Matteo Croce <technoboy85@gmail.com>
Cc: linux-mips@linux-mips.org, Felix Fietkau <nbd@openwrt.org>,
linux-mtd@lists.infradead.org, Eugene Konev <ejka@imfi.kspu.ru>
Subject: Re: [PATCH][MIPS][2/7] AR7: mtd
Date: Thu, 06 Sep 2007 16:41:22 +0100 [thread overview]
Message-ID: <1189093282.2745.147.camel@shinybook.infradead.org> (raw)
In-Reply-To: <200709061723.21091.technoboy85@gmail.com>
On Thu, 2007-09-06 at 17:23 +0200, Matteo Croce wrote:
> + unsigned int pre_size = master->erasesize, post_size = 0,
> + root_offset = 0xe0000;
Separate lines for those, please.
> + int retries = 10;
> +
> + printk("Parsing AR7 partition map...\n");
Needs priority. (As do one or two other printks).
> + do {
> + offset = pre_size;
> + master->read(master, offset, sizeof(header), &len, (u_char
> *)&header);
> + if (!strncmp((char *)&header, "TIENV0.8", 8))
> + ar7_parts[1].offset = pre_size;
> + if (header.checksum == 0xfeedfa42)
> + break;
> + if (header.checksum == 0xfeed1281)
> + break;
> + pre_size += master->erasesize;
> + } while (retries--);
Needs some comments. What are the magic numbers? What is this retry
thing all about?
Endianness?
> +MODULE_LICENSE("GPL");
> +MODULE_AUTHOR("Felix Fietkau, Eugene Konev");
Normally I prefer to see email addresses in MODULE_AUTHOR(). You missed
them from the comments at the top of the file too.
--
dwmw2
prev parent reply other threads:[~2007-09-06 15:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200708201704.11529.technoboy85@gmail.com>
2007-09-06 15:23 ` [PATCH][MIPS][2/7] AR7: mtd Matteo Croce
2007-09-06 15:41 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1189093282.2745.147.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=ejka@imfi.kspu.ru \
--cc=linux-mips@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nbd@openwrt.org \
--cc=technoboy85@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox