Re: JFFS2 ACL problem.

[David Woodhouse <dwmw2@infradead.org>]

On Fri, 2007-09-14 at 15:16 +0900, KaiGai Kohei wrote:
> 
> The attached patch separate jffs2_init_acl() into two parts.
> 
> The one is jffs2_init_acl_pre() called from jffs2_new_inode().
> It compute ACL oriented inode->i_mode bits, and allocate in-memory ACL
> objects associated with the new inode just before when inode meta
> infomation is written to the medium.
> 
> The other is jffs2_init_acl_post() called from jffs2_symlink(),
> jffs2_mkdir(), jffs2_mknod() and jffs2_do_create().
> It actually writes in-memory ACL objects into the medium next to
> the success of writing meta-information.
> 
> In the current implementation, we have to write a same inode meta
> infomation twice when inode->i_mode is updated by the default ACL.
> However, we can avoid the behavior by putting an updated i_mode
> before it is written at first, as jffs2_init_acl_pre() doing.
> 
> Please review this patch.

At first glance, that looks much nicer than what I did -- thanks.

I should hopefully have some time later today to take a closer look and
merge it.

-- 
dwmw2