From: Artem Bityutskiy <dedekind@infradead.org>
To: kmpark@infradead.org
Cc: linux-mtd@lists.infradead.org,
'Adrian Hunter' <ext-adrian.hunter@nokia.com>
Subject: RE: [PATCH] MTD: OneNAND: Return only negative error codes
Date: Sun, 14 Oct 2007 11:14:08 +0300 [thread overview]
Message-ID: <1192349648.3455.1.camel@sauron> (raw)
In-Reply-To: <003801c80cb2$8d594910$e1ac580a@swcenter.sec.samsung.co.kr>
On Fri, 2007-10-12 at 18:30 +0900, Kyungmin Park wrote:
> > The OneNAND driver was confusing JFFS2 by returning positive error
> > codes.
>
> It's only possible the write case error and it returns the positive 'ctrl' error.
> Other case, "2-bit ecc error' is handled with 'mtd->ecc_stat' correctly.
>
> Well, no problem to change to the negative value.
>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
Yeah, it's rare but we caught this in practice, and JFFS2 just calls
BUG() if OneNAND returns positive number while JFFS2 is scanning the
flash medium.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
prev parent reply other threads:[~2007-10-14 8:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 7:19 [PATCH] MTD: OneNAND: Return only negative error codes Adrian Hunter
2007-10-12 9:30 ` Kyungmin Park
2007-10-14 8:14 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1192349648.3455.1.camel@sauron \
--to=dedekind@infradead.org \
--cc=ext-adrian.hunter@nokia.com \
--cc=kmpark@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox