From: Artem Bityutskiy <dedekind@infradead.org>
To: "Jörn Engel" <joern@logfs.org>
Cc: linux-mtd@lists.infradead.org, Matt Reimer <mattjreimer@gmail.com>
Subject: Re: [PATCH] MTD: make s3c2410's correct_data indicate an error for multi-bit read errors
Date: Fri, 19 Oct 2007 12:00:47 +0300 [thread overview]
Message-ID: <1192784447.3421.27.camel@sauron> (raw)
In-Reply-To: <20071019082438.GA26913@lazybastard.org>
On Fri, 2007-10-19 at 10:24 +0200, Jörn Engel wrote:
> > @@ -397,7 +397,7 @@ static int s3c2410_nand_correct_data(struct
> > mtd_info *mtd, u_char *dat,
> > if ((diff0 & ~(1<<fls(diff0))) == 0)
> > return 1;
> >
> > - return 0;
> > + return -1;
> > }
Yup, Jörn is right, you should return -EBADMSG on ECC errors and
-EUCLEAN if there was a correctable bit-flip.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2007-10-19 9:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 1:13 [PATCH] MTD: make s3c2410's correct_data indicate an error for multi-bit read errors Matt Reimer
2007-10-19 8:24 ` Jörn Engel
2007-10-19 9:00 ` Artem Bityutskiy [this message]
2007-10-19 19:29 ` Matt Reimer
2007-10-20 10:28 ` Jörn Engel
-- strict thread matches above, loose matches on Subject: below --
2007-10-20 16:48 Matt Reimer
2007-10-25 18:12 ` Matt Reimer
2007-10-20 16:44 Matt Reimer
2007-10-20 16:49 ` Matt Reimer
2007-10-19 1:02 [PATCH] MTD: fix s3c2410 error correction Matt Reimer
2007-10-19 1:02 ` [PATCH] MTD: make s3c2410's correct_data indicate an error for multi-bit read errors Matt Reimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1192784447.3421.27.camel@sauron \
--to=dedekind@infradead.org \
--cc=joern@logfs.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mattjreimer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox