* [PATCH] cfi: make cfi_staa_erase_varsize static to shut up sparse
@ 2007-11-16 13:29 Andre Haupt
2007-11-16 14:10 ` Jörn Engel
0 siblings, 1 reply; 2+ messages in thread
From: Andre Haupt @ 2007-11-16 13:29 UTC (permalink / raw)
To: linux-mtd; +Cc: Andre Haupt, joern
should this be static?
From: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
---
drivers/mtd/chips/cfi_cmdset_0020.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/chips/cfi_cmdset_0020.c b/drivers/mtd/chips/cfi_cmdset_0020.c
index b344ff8..07a3dd4 100644
--- a/drivers/mtd/chips/cfi_cmdset_0020.c
+++ b/drivers/mtd/chips/cfi_cmdset_0020.c
@@ -893,7 +893,7 @@ retry:
return ret;
}
-int cfi_staa_erase_varsize(struct mtd_info *mtd, struct erase_info *instr)
+static int cfi_staa_erase_varsize(struct mtd_info *mtd, struct erase_info *instr)
{ struct map_info *map = mtd->priv;
struct cfi_private *cfi = map->fldrv_priv;
unsigned long adr, len;
--
1.4.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] cfi: make cfi_staa_erase_varsize static to shut up sparse
2007-11-16 13:29 [PATCH] cfi: make cfi_staa_erase_varsize static to shut up sparse Andre Haupt
@ 2007-11-16 14:10 ` Jörn Engel
0 siblings, 0 replies; 2+ messages in thread
From: Jörn Engel @ 2007-11-16 14:10 UTC (permalink / raw)
To: Andre Haupt; +Cc: joern, linux-mtd
On Fri, 16 November 2007 14:29:55 +0100, Andre Haupt wrote:
>
> should this be static?
Looks like it.
> From: Andre Haupt <andre@bitwigglers.org>
> Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Acked-by: Joern Engel <joern@logfs.org>
> ---
> drivers/mtd/chips/cfi_cmdset_0020.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/chips/cfi_cmdset_0020.c b/drivers/mtd/chips/cfi_cmdset_0020.c
> index b344ff8..07a3dd4 100644
> --- a/drivers/mtd/chips/cfi_cmdset_0020.c
> +++ b/drivers/mtd/chips/cfi_cmdset_0020.c
> @@ -893,7 +893,7 @@ retry:
> return ret;
> }
>
> -int cfi_staa_erase_varsize(struct mtd_info *mtd, struct erase_info *instr)
> +static int cfi_staa_erase_varsize(struct mtd_info *mtd, struct erase_info *instr)
> { struct map_info *map = mtd->priv;
> struct cfi_private *cfi = map->fldrv_priv;
> unsigned long adr, len;
> --
> 1.4.4.4
>
Jörn
--
The strong give up and move away, while the weak give up and stay.
-- unknown
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-16 14:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-16 13:29 [PATCH] cfi: make cfi_staa_erase_varsize static to shut up sparse Andre Haupt
2007-11-16 14:10 ` Jörn Engel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox