Re: [PATCH 4/5] UBI: introduce attach ioctls

Frank Haverkamp
2008-01-03T15:44:17Z

[-- Attachment #1: Type: text/plain, Size: 1486 bytes --]

Hi Arnd,

On Thu, 2008-01-03 at 16:05 +0100, Arnd Bergmann wrote:
> On Thursday 03 January 2008, Frank Haverkamp wrote:
> > > We can autoprobe the VID header offset, unless the MTD device is empty,
> > > in which case UBI automatically formats it.
> >
> > I do not like auto-probing the VID hdr offset. In my eyes the user
> > should have the flexibility to define where his VID-hdr and data start
> > e.g. like in our case to have influence on if data is starting on
> > subpage- or page-boundaries. I also think that the autoprobe feature
> > would add more complexity to the code.
>
> I agree that the user should have the flexibility to set these parameters,
> but AFAICS, that is only relevant during initialization (formatting) of
> the medium.
>
> However, I find it essential that it's possible to do autoprobing of
> existing media, by whatever means.
> If you don't want to do it in the kernel, a user space helper might
> be useful, preferably one that does not require ioctls, so it can be
> done as a shell script.

Yes, a user-space tool to figure out the values seems to me a good idea.
It helps moving the complexity to user-space which you would otherwise
have in the kernel-code.

Frank
--
IBM Deutschland Entwicklung GmbH, Schoenaicher Str. 220, 71032
Boeblingen, Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Herbert Kircher, Sitz der Gesellschaft: Böblingen,
Registergericht: Amtsgericht Stuttgart, HRB 243294

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5269 bytes --]