Linux-mtd Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Dominique Martinet <dominique.martinet@atmark-techno.com>
Cc: stable <stable@vger.kernel.org>,
	chengzhihao1 <chengzhihao1@huawei.com>,
	 Miquel Raynal <miquel.raynal@bootlin.com>,
	 linux-mtd <linux-mtd@lists.infradead.org>,
	 linux-kernel <linux-kernel@vger.kernel.org>,
	 Cheng Ming Lin <chengminglin@mxic.com.tw>,
	 Liyuan Pang <pangliyuan1@huawei.com>
Subject: Re: [PATCH 0/2] Backport fixes for UBI
Date: Wed, 19 Aug 2026 12:48:28 +0200 (CEST)	[thread overview]
Message-ID: <1200997805.161072.1787136508436.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20260818-ubi-backports-v1-0-324d6816d2ae@atmark-techno.com>

----- Ursprüngliche Mail -----
> Von: "Dominique Martinet" <dominique.martinet@atmark-techno.com>
> While looking at recent UBI patches I found these two commits that I
> believe are worth backporting.
> 
> We're not using fastmap so I don't care much about the leak there, but
> reducing wear is always good to take
> 
> Thanks!
> 
> Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com>
> ---
> Cheng Ming Lin (1):
>      mtd: ubi: skip programming unused bits in ubi headers
> 
> Liyuan Pang (1):
>      ubi: fastmap: fix ubi->fm memory leak

While porting these back is not wrong, I have a hard time to see how the
current stables rules apply here.

"mtd: ubi: skip programming unused bits in ubi headers" does not fix anything.
It's a pure optimization for future flashes, UBI worked since ever without this
change.

"ubi: fastmap: fix ubi->fm memory leak" fixes a memory leak, yes. But only in a failure
path at attach time. Userspace cannot trigger this.

Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2026-08-19 10:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18  2:09 [PATCH 0/2] Backport fixes for UBI Dominique Martinet
2026-08-18  2:09 ` [PATCH v6.12.y 1/2] mtd: ubi: skip programming unused bits in ubi headers Dominique Martinet
2026-08-18  4:46   ` Zhihao Cheng
2026-08-18  2:09 ` [PATCH v6.12.y 2/2] ubi: fastmap: fix ubi->fm memory leak Dominique Martinet
2026-08-18  4:47   ` Zhihao Cheng
2026-08-19  3:32 ` [PATCH 0/2] Backport fixes for UBI Sasha Levin
2026-08-19 10:48 ` Richard Weinberger [this message]
2026-08-20  0:57   ` Dominique Martinet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1200997805.161072.1787136508436.JavaMail.zimbra@nod.at \
    --to=richard@nod.at \
    --cc=chengminglin@mxic.com.tw \
    --cc=chengzhihao1@huawei.com \
    --cc=dominique.martinet@atmark-techno.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=pangliyuan1@huawei.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox