Re: [PATCH] [JFFS2] Fix free space leaking

[Joakim Tjernlund <joakim.tjernlund@transmode.se>]

On Tue, 2007-11-13 at 13:23 +0300, Damir Shayhutdinov wrote:
> This patch is addressed to fix very-long-standing problem in JFFS2,
> first described in 2004:
> http://lists.infradead.org/pipermail/linux-mtd/2004-March/009456.html
> 
> jffs2_link_node_ref() decreases c->free_size by
> c->cleanmarker_size but the clean marker space can't
> be accounted as free space! So we just compensate
> the difference.
> 
> Signed-off-by: Alexander Yurchenko <grange@tecon.ru>
> Signed-off-by: Damir Shayhutdinov <damir@tecon.ru>
> ---
>  fs/jffs2/erase.c |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/jffs2/erase.c b/fs/jffs2/erase.c
> index a1db918..c574fa3 100644
> --- a/fs/jffs2/erase.c
> +++ b/fs/jffs2/erase.c
> @@ -454,6 +454,17 @@ static void jffs2_mark_erased_block(struct jffs2_sb_info *c, struct jffs2_eraseb
>  		jeb->free_size = c->sector_size;
>  		/* FIXME Special case for cleanmarker in empty block */
>  		jffs2_link_node_ref(c, jeb, jeb->offset | REF_NORMAL, c->cleanmarker_size, NULL);
> +		/*
> +		 * XXX: I'm not sure this is correct but it prevents
> +		 * c->free_size from slow leaking under a frequent file
> +		 * overwriting.
> +		 * jffs2_link_node_ref() decreases c->free_size by
> +		 * c->cleanmarker_size but the clean marker space can't
> +		 * be accounted as free space! So we just compensate
> +		 * the difference.
> +		 */
> +		c->free_size += c->cleanmarker_size;
> +		c->used_size -= c->cleanmarker_size;
>  	}
>  
>  	down(&c->erase_free_sem);

What happened to this patch? Just forgotten or was it rejected?

   Jocke