From: David Woodhouse <dwmw2@infradead.org>
To: Alexey Korolev <akorolev@infradead.org>
Cc: nickpiggin@yahoo.com.au, joern@logfs.org,
linux-mtd@lists.infradead.org, akpm@linux-foundation.org,
vailiy.leonenko@intel.com
Subject: Re: [PATCH] JFFS2 Fix of panics caused by wrong condition for hole frag creation in write_begin
Date: Mon, 14 Apr 2008 20:40:28 +0100 [thread overview]
Message-ID: <1208202028.3005.37.camel@pmac.infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0804141747020.15842@pentafluge.infradead.org>
On Mon, 2008-04-14 at 17:55 +0100, Alexey Korolev wrote:
> Hi,
>
>
> JFFS2 in Linux 2.6.24 fails to kernel panic on random read/write/truncate operatons. We investigated the issue it is caused by
> bug in conditions for hole fragment creation in write_begin function. Offset of starting offset which is used to identify should we create hole frag or not is calculated improperly.
> As result hole frags are not created when they must be - it leads to internal memory corruptions and kernel panic.
>
> The following patch fixes the bug in JFFS2 write_begin hole frag conditions.
> Please include the patch.
Well spotted, Alexey. Thanks!
I've simplified it a little and sent it to Linus.
--
dwmw2
next prev parent reply other threads:[~2008-04-14 19:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-14 16:55 [PATCH] JFFS2 Fix of panics caused by wrong condition for hole frag creation in write_begin Alexey Korolev
2008-04-14 18:21 ` Jörn Engel
2008-04-14 19:40 ` David Woodhouse [this message]
2008-04-14 19:50 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208202028.3005.37.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=akorolev@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=joern@logfs.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nickpiggin@yahoo.com.au \
--cc=vailiy.leonenko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox