public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind@infradead.org>
To: Hamish Moffatt <hamish@cloud.net.au>
Cc: dwmw2@infradead.org, Thomas Gleixner <tglx@linutronix.de>,
	linux-mtd@lists.infradead.org,
	Alexey Korolev <akorolev@infradead.org>
Subject: Re: [RFC][patch] NAND partial page read functionality
Date: Thu, 24 Apr 2008 12:53:59 +0300	[thread overview]
Message-ID: <1209030839.11721.115.camel@sauron> (raw)
In-Reply-To: <20080424074526.GA21709@cloud.net.au>

On Thu, 2008-04-24 at 17:45 +1000, Hamish Moffatt wrote:
> The rest of the discussion was about improved use of sub-page writes.
> I'm sure that would be useful but it's not strictly relevant to the
> partial read patch.
Yup.

> Artem, were you able to try the patch on the OLPC with hardware ECC, as
> you hinted in the original discussion?

Right, I completely forgot to do this. I've just verified - OLPC works
just fine with this patch. It also does not affect our OneNAND setup.

> Also I reverted your recent patch to combine the EC + VID header reads
> in the UBI scan for this test. I think with partial reads it may make 
> things slower, because it will force 2K to be read (or 576 bytes if the 
> ALIGN() is removed, still more than 64 + 64). Because min_io_size = 2K
> is not really accurate I guess.

I deliberately did that. I though making one call instead of 2 is
better, because MTD anyway reads whole page. And my other motivation was
that flashes like OneNAND which may read 2 consecutive pages faster
(kind of "burst" read). Although for OneNAND this trick does not really
work. Anyway, lets forget about that patch.

I think if Alexey is not any more interested in working on his patch,
you could do this, if you are interested. I am going to be away till the
5 of May, so I won't be able to help.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

  reply	other threads:[~2008-04-24  9:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-13 18:15 [RFC][patch] NAND partial page read functionality Alexey Korolev
2007-12-15 12:13 ` Artem Bityutskiy
2007-12-17 15:46   ` Alexey Korolev
2007-12-18  8:48     ` Artem Bityutskiy
2007-12-18 11:42       ` Jörn Engel
2007-12-18 12:57         ` Artem Bityutskiy
2007-12-18 13:51           ` Jörn Engel
2008-04-24  6:34 ` Artem Bityutskiy
2008-04-24  7:11   ` Artem Bityutskiy
2008-04-24  7:45   ` Hamish Moffatt
2008-04-24  9:53     ` Artem Bityutskiy [this message]
2008-04-24 10:25     ` Alexey Korolev
2008-04-24 10:45       ` Artem Bityutskiy
2008-04-24 10:57         ` Alexey Korolev
2008-04-24 14:04       ` Hamish Moffatt
2008-04-24 14:48         ` Alexey Korolev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1209030839.11721.115.camel@sauron \
    --to=dedekind@infradead.org \
    --cc=akorolev@infradead.org \
    --cc=dwmw2@infradead.org \
    --cc=hamish@cloud.net.au \
    --cc=linux-mtd@lists.infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox