public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: "Andrew E. Mileski" <andrewm@isoar.ca>
To: linux-mtd@lists.infradead.org
Subject: [PATCH] nand_wait_ready() timeout scaling
Date: Wed, 30 Apr 2008 15:22:55 -0400	[thread overview]
Message-ID: <1209583375-11136-1-git-send-email-andrewm@isoar.ca> (raw)

The nand_wait_ready() timeout was hardcoded to 2 jiffies, which does not
scale with the system timer frequency.  Using a guess of a 250 Hz system
timer frequency, I believe the timeout was meant to be 8 ms.  This patch
sets an 8 ms timeout that scales with the system timer frequency.

Tested with a 1000 Hz system timer frequency and with a device requiring
at least a 3 ms timeout.

Signed-off-by: Andrew E. Mileski <andrewm@isoar.ca>
--

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index ba1bdf7..ef7e1c1 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -415,13 +415,13 @@ static int nand_block_checkbad(struct mtd_info *mtd, loff_t ofs, int getchip,
 }
 
 /*
- * Wait for the ready pin, after a command
- * The timeout is catched later.
+ * Wait 8 ms for the ready pin, after a command
+ * The timeout is caught later.
  */
 void nand_wait_ready(struct mtd_info *mtd)
 {
 	struct nand_chip *chip = mtd->priv;
-	unsigned long timeo = jiffies + 2;
+	unsigned long timeo = jiffies + (HZ * 8) / 1000;
 
 	led_trigger_event(nand_led_trigger, LED_FULL);
 	/* wait until command is processed or timeout occures */

             reply	other threads:[~2008-04-30 19:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-30 19:22 Andrew E. Mileski [this message]
2008-04-30 19:46 ` [PATCH] nand_wait_ready() timeout scaling Andrew E. Mileski
2008-04-30 20:19   ` Trent Piepho
2008-04-30 20:55     ` Andrew E. Mileski
2008-07-14 20:32 ` Andrew E. Mileski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1209583375-11136-1-git-send-email-andrewm@isoar.ca \
    --to=andrewm@isoar.ca \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox