Re: [PATCH] mkfs.ubifs: support --squash-uids

Artem Bityutskiy
2008-05-06T06:39:13Z

On Mon, 2008-05-05 at 18:46 +1000, Hamish Moffatt wrote:
> > Thanks for the patch. Before applying it, we'd like to know what do you
> > expect to happen if -U is used simultaneously with the device table
> > (-D). Should we use what device table says for directories which are
> > created because they are specified in the device table, or we should use
> > 0 anyway? Or we should just prohibit simultaneous usage of -U and -D ?
>
> Good point. mkfs.jffs2 (from my reading of the source code) squashes
> ownership of files read from the specified root directory, but the
> ownerships specified in the device table are still used. I think that
> makes sense, because you can always specify 0:0 in the device table if
> that's what you need.
>
> However it's not what is implemented by my patch :-) Would you like me
> to fix it up and resubmit, or will you? I applied the squashing at the
> lowest level without realizing the effect on the device table.

I've committed your patch and will do the "prefer dev. table" change
later. Just a note - the patch was against some old mkfs.ubifs, so I had
to do conflict resolution. Also note, we changed -p (--orph-lebs) option
to -P at some point. You are unlikely using it - this is just for
information.

Thank you!