Re: [PATCH] mkfs.ubifs: support --squash-uids

Hamish Moffatt
2008-05-05T08:46:25Z

On Mon, May 05, 2008 at 10:31:12AM +0300, Artem Bityutskiy wrote:
>
> On Fri, 2008-05-02 at 15:16 +1000, Hamish Moffatt wrote:
> > mkfs.jffs2 and genext2fs both have a -U/--squash-uids switch which make
> > them ignore the uid/gids in the directory and set them to 0:0 instead.
> >
> > Here's my implementation for mkfs.ubifs.
> >
> > Signed-off-by: Hamish Moffatt <hamish@cloud.net.au>
> >
>
> Thanks for the patch. Before applying it, we'd like to know what do you
> expect to happen if -U is used simultaneously with the device table
> (-D). Should we use what device table says for directories which are
> created because they are specified in the device table, or we should use
> 0 anyway? Or we should just prohibit simultaneous usage of -U and -D ?

Good point. mkfs.jffs2 (from my reading of the source code) squashes
ownership of files read from the specified root directory, but the
ownerships specified in the device table are still used. I think that
makes sense, because you can always specify 0:0 in the device table if
that's what you need.

However it's not what is implemented by my patch :-) Would you like me
to fix it up and resubmit, or will you? I applied the squashing at the
lowest level without realizing the effect on the device table.

thanks,
Hamish
--
Hamish Moffatt VK3SB <hamish@debian.org> <hamish@cloud.net.au>