[PATCH] UBI: Fix 64-bit calculations

[PATCH] UBI: Fix 64-bit calculations

[Bruce_Leonard]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

Artem,

I found another place where promotion was clobbering the 64-bit result. 
I'm attaching it rather than sending it inline because my mailer evidently 

has a problem with line wraps that I haven't figured out how to fix. 
Hopefully it comes through okay.  My apologies to the list.

Bruce


[-- Attachment #2: cdev.c patch --]
[-- Type: application/octet-stream, Size: 649 bytes --]

Signed-off-by: Bruce Leonard <brucle@selinc.com>

diff --git a/drivers/mtd/ubi/cdev.c b/drivers/mtd/ubi/cdev.c
index 34175ec..88f1b6f 100644
--- a/drivers/mtd/ubi/cdev.c
+++ b/drivers/mtd/ubi/cdev.c
@@ -432,7 +432,7 @@ static int vol_cdev_ioctl(struct inode *inode, struct file *file,
                        break;
                }
 
-               rsvd_bytes = vol->reserved_pebs * (ubi->leb_size-vol->data_pad);
+               rsvd_bytes = (long long)vol->reserved_pebs * (ubi->leb_size-vol->data_pad);
                if (bytes < 0 || bytes > rsvd_bytes) {
                        err = -EINVAL;
                        break;

Re: [PATCH] UBI: Fix 64-bit calculations

[Artem Bityutskiy]

On Wed, 2008-07-02 at 21:55 -0700, Bruce_Leonard@selinc.com wrote:
> Artem,
> 
> I found another place where promotion was clobbering the 64-bit result. 
> I'm attaching it rather than sending it inline because my mailer evidently 
> 
> has a problem with line wraps that I haven't figured out how to fix. 
> Hopefully it comes through okay.  My apologies to the list.

Thanks for the patch - applied and pushed
-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)