From: David Woodhouse <dwmw2@infradead.org>
To: Bryan Wu <cooloney@kernel.org>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Mike Frysinger <vapier.adi@gmail.com>
Subject: Re: [PATCH 1/1] MTD Maps: initial driver for using gpios to assist in addressing of parallel flash as is on the tinyboards
Date: Fri, 15 Aug 2008 10:29:53 +0100 [thread overview]
Message-ID: <1218792593.3184.71.camel@pmac.infradead.org> (raw)
In-Reply-To: <1218789421-9995-1-git-send-email-cooloney@kernel.org>
On Fri, 2008-08-15 at 16:37 +0800, Bryan Wu wrote:
> +#define pr_devinit(fmt, args...) ({ static const __devinitconst char
> __fmt[] = fmt; printk(__fmt, ## args); })
You've added that macro twice in MTD code already -- and now you're
adding it twice more (although I suspect only one was intentional).
Where are we with putting it in include/linux/ where it belongs?
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2008-08-15 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 8:37 [PATCH 1/1] MTD Maps: initial driver for using gpios to assist in addressing of parallel flash as is on the tinyboards Bryan Wu
2008-08-15 9:29 ` David Woodhouse [this message]
2008-08-15 12:48 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218792593.3184.71.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=cooloney@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox