Re: [PATCH] Remove duplicated unlikely() in IS_ERR()

Christof Schmitt
2008-08-18T15:21:41Z

On Fri, Aug 15, 2008 at 04:16:57PM +0900, Hirofumi Nakagawa wrote:
> Hi
> Some drivers have duplicated unlikely() macros.
> IS_ERR() already has unlikely() in itself.
> This patch cleans up such pointless codes although there is no real
> effect on the kernel's behaviour.
>
> Thanks,
> Hirofumi Nakagawa
>
> Signed-off-by: Hirofumi Nakagawa <hnakagawa@miraclelinux.com>
> ---
> drivers/s390/scsi/zfcp_fsf.c | 32 ++++++++++++++++----------------
> fs/ubifs/find.c | 4 ++--
> fs/ubifs/gc.c | 8 ++++----
> fs/ubifs/tnc.c | 4 ++--
> fs/ubifs/xattr.c | 2 +-
> net/ipv6/af_inet6.c | 2 +-
> 6 files changed, 26 insertions(+), 26 deletions(-)

Thanks for spotting and fixing this. Could you split the zfcp changes
in a seperate patch? I will pick up the zfcp patch for a series of
fixes that i have pending here.

Christof