public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: linux-mtd@lists.infradead.org
Subject: [PATCH] mkfs.ubifs: set CFLAGS/LDLIBS properly
Date: Wed, 20 Aug 2008 13:57:09 -0400	[thread overview]
Message-ID: <1219255029-22308-1-git-send-email-vapier@gentoo.org> (raw)

CFLAGS should only be set as a default instead of overriding the user's
choices.  LDLIBS is for adding libraries, not LDFLAGS.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 mkfs.ubifs/Makefile |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/mkfs.ubifs/Makefile b/mkfs.ubifs/Makefile
index 9487c14..467ae1a 100644
--- a/mkfs.ubifs/Makefile
+++ b/mkfs.ubifs/Makefile
@@ -1,8 +1,9 @@
 DESTDIR := /usr/local
 SBINDIR=/usr/sbin
 ALL_SOURCES=*.[ch] hashtable/*.[ch]
-CFLAGS := $(CFLAGS) -Wall -O0 -ggdb
-LDFLAGS := $(LDFLAGS) -lz -llzo2 -lm -luuid
+CFLAGS ?= -O0 -ggdb
+CFLAGS += -Wall
+LDLIBS += -lz -llzo2 -lm -luuid
 TARGETS = mkfs.ubifs
 
 all: $(TARGETS)
-- 
1.5.6.5

             reply	other threads:[~2008-08-20 17:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-20 17:57 Mike Frysinger [this message]
2008-08-21  7:18 ` [PATCH] mkfs.ubifs: set CFLAGS/LDLIBS properly Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1219255029-22308-1-git-send-email-vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox