From: Artem Bityutskiy <dedekind@infradead.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mkfs.ubifs: set CFLAGS/LDLIBS properly
Date: Thu, 21 Aug 2008 10:18:58 +0300 [thread overview]
Message-ID: <1219303138.18027.52.camel@sauron> (raw)
In-Reply-To: <1219255029-22308-1-git-send-email-vapier@gentoo.org>
Hi,
On Wed, 2008-08-20 at 13:57 -0400, Mike Frysinger wrote:
> CFLAGS should only be set as a default instead of overriding the user's
> choices. LDLIBS is for adding libraries, not LDFLAGS.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> mkfs.ubifs/Makefile | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
Thanks, applied.
> -CFLAGS := $(CFLAGS) -Wall -O0 -ggdb
> -LDFLAGS := $(LDFLAGS) -lz -llzo2 -lm -luuid
> +CFLAGS ?= -O0 -ggdb
This is forgotten debugging hack leftover, I've removed it.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
prev parent reply other threads:[~2008-08-21 7:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 17:57 [PATCH] mkfs.ubifs: set CFLAGS/LDLIBS properly Mike Frysinger
2008-08-21 7:18 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219303138.18027.52.camel@sauron \
--to=dedekind@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox