* [PATCH] mkfs.ubifs: set CFLAGS/LDLIBS properly
@ 2008-08-20 17:57 Mike Frysinger
2008-08-21 7:18 ` Artem Bityutskiy
0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2008-08-20 17:57 UTC (permalink / raw)
To: linux-mtd
CFLAGS should only be set as a default instead of overriding the user's
choices. LDLIBS is for adding libraries, not LDFLAGS.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
mkfs.ubifs/Makefile | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/mkfs.ubifs/Makefile b/mkfs.ubifs/Makefile
index 9487c14..467ae1a 100644
--- a/mkfs.ubifs/Makefile
+++ b/mkfs.ubifs/Makefile
@@ -1,8 +1,9 @@
DESTDIR := /usr/local
SBINDIR=/usr/sbin
ALL_SOURCES=*.[ch] hashtable/*.[ch]
-CFLAGS := $(CFLAGS) -Wall -O0 -ggdb
-LDFLAGS := $(LDFLAGS) -lz -llzo2 -lm -luuid
+CFLAGS ?= -O0 -ggdb
+CFLAGS += -Wall
+LDLIBS += -lz -llzo2 -lm -luuid
TARGETS = mkfs.ubifs
all: $(TARGETS)
--
1.5.6.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mkfs.ubifs: set CFLAGS/LDLIBS properly
2008-08-20 17:57 [PATCH] mkfs.ubifs: set CFLAGS/LDLIBS properly Mike Frysinger
@ 2008-08-21 7:18 ` Artem Bityutskiy
0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2008-08-21 7:18 UTC (permalink / raw)
To: Mike Frysinger; +Cc: linux-mtd
Hi,
On Wed, 2008-08-20 at 13:57 -0400, Mike Frysinger wrote:
> CFLAGS should only be set as a default instead of overriding the user's
> choices. LDLIBS is for adding libraries, not LDFLAGS.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> mkfs.ubifs/Makefile | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
Thanks, applied.
> -CFLAGS := $(CFLAGS) -Wall -O0 -ggdb
> -LDFLAGS := $(LDFLAGS) -lz -llzo2 -lm -luuid
> +CFLAGS ?= -O0 -ggdb
This is forgotten debugging hack leftover, I've removed it.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-08-21 7:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-20 17:57 [PATCH] mkfs.ubifs: set CFLAGS/LDLIBS properly Mike Frysinger
2008-08-21 7:18 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox