From: Artem Bityutskiy <dedekind@infradead.org>
To: "Singh, Vimal" <vimalsingh@ti.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
frans <fransmeulenbroeks@gmail.com>,
Woodhouse <dwmw2@infradead.org>,
David@mgw-mx06.nokia.com
Subject: RE: [PATCH] [MTD] [NAND] nand_ecc.c: adding support for 512 byte ecc
Date: Thu, 21 Aug 2008 13:55:03 +0300 [thread overview]
Message-ID: <1219316103.18027.60.camel@sauron> (raw)
In-Reply-To: <19F8576C6E063C45BE387C64729E739403CD517C1A@dbde02.ent.ti.com>
Hi,
> + /* 256 or 512 bytes/ecc */
> + uint32_t j =(((struct nand_chip *)mtd->priv)->ecc.size)/256;
It's certainly faster to use >> 8 instead. At least on x86 GCC would not
optimize this for you if the kernel is compiles with -Os, it would use
idiv instead.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2008-08-21 10:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <19F8576C6E063C45BE387C64729E739403CD517C16@dbde02.ent.ti.com>
2008-08-21 10:51 ` [PATCH] [MTD] [NAND] nand_ecc.c: adding support for 512 byte ecc Singh, Vimal
2008-08-21 10:55 ` Artem Bityutskiy [this message]
2008-08-21 18:39 ` Frans Meulenbroeks
2008-08-22 5:39 ` Singh, Vimal
2008-08-22 5:53 ` Artem Bityutskiy
2008-08-22 6:07 ` Artem Bityutskiy
2008-08-22 8:43 ` Frans Meulenbroeks
2008-08-22 9:06 ` David Woodhouse
2008-08-22 8:45 ` Singh, Vimal
2008-08-22 8:58 ` Frans Meulenbroeks
2008-08-22 9:27 ` Singh, Vimal
2008-08-23 16:18 ` frans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219316103.18027.60.camel@sauron \
--to=dedekind@infradead.org \
--cc=David@mgw-mx06.nokia.com \
--cc=dwmw2@infradead.org \
--cc=fransmeulenbroeks@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=vimalsingh@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox