From: David Woodhouse <dwmw2@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Rodolfo Giometti <giometti@enneenne.com>,
Zev Weiss <zevweiss@gmail.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [MTD] mtdchar.c: Fix regression in MEMGETREGIONINFO ioctl()
Date: Mon, 25 Aug 2008 12:37:37 +0100 [thread overview]
Message-ID: <1219664257.9583.36.camel@pmac.infradead.org> (raw)
In-Reply-To: <20080823222707.2fb972b5.akpm@linux-foundation.org>
On Sat, 2008-08-23 at 22:27 -0700, Andrew Morton wrote:
>
> > On the other hand, if I'm missing something completely, please let me know,
> > and perhaps I can prepare a more suitable fix.
>
> "good enough" is never good enough ;)
>
> What is the ideal implementation? Let's implement that.
It involves ditching the ioctls altogether (well, not adding anything
_more_ to them, at least) and doing it through sysfs.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2008-08-25 11:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 7:47 [PATCH] [MTD] mtdchar.c: Fix regression in MEMGETREGIONINFO ioctl() Zev Weiss
2008-08-22 22:34 ` Andrew Morton
2008-08-23 8:10 ` Zev Weiss
2008-08-24 5:27 ` Andrew Morton
2008-08-24 11:01 ` Zev Weiss
2008-08-27 4:31 ` Zev Weiss
2008-09-01 11:01 ` David Woodhouse
2008-09-01 12:19 ` Zev Weiss
2008-09-01 17:25 ` David Woodhouse
2008-08-25 11:37 ` David Woodhouse [this message]
2008-08-24 12:38 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219664257.9583.36.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=giometti@enneenne.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=zevweiss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox