From: Artem Bityutskiy <dedekind@infradead.org>
To: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd-utils: allow 'ubiformat' to read from stdin
Date: Tue, 26 Aug 2008 09:13:43 +0300 [thread overview]
Message-ID: <1219731223.18027.116.camel@sauron> (raw)
In-Reply-To: <1219691391-15149-2-git-send-email-enrico.scholz@sigma-chemnitz.de>
On Mon, 2008-08-25 at 21:09 +0200, Enrico Scholz wrote:
> This patch allows to read the image from stdin and adds an
> '--image-size' option to specify its size. 'upiupdatevol' has this
> feature already and it is useful for 'ubiformat' too.
>
> It adds a read_all() function which reads a block of data. Plain
> 'read(2)' can fail on
>
> nc -l -p 1234 | ubiformat -f - -S 25427968
>
> else.
Applied, pushed, but with few minor tweaks to make the utilities be
uni-styled. Thanks.
> + int fd;
Here I've removed TABs between "int" and "fd", and put a space.
> + ssize_t l = read(fd, buf, len);
And here.
> - struct stat st;
> + off_t st_size;
And here.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2008-08-26 6:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-25 19:09 [PATCH] mtd-utils: fixed and enhanced '--flash-image' option Enrico Scholz
2008-08-25 19:09 ` [PATCH] mtd-utils: allow 'ubiformat' to read from stdin Enrico Scholz
2008-08-26 6:13 ` Artem Bityutskiy [this message]
2008-08-26 5:21 ` [PATCH] mtd-utils: fixed and enhanced '--flash-image' option Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219731223.18027.116.camel@sauron \
--to=dedekind@infradead.org \
--cc=enrico.scholz@sigma-chemnitz.de \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox