Re: [RFC] mtd-utils: make cross build functional again

[Artem Bityutskiy <dedekind@infradead.org>]

Hi,

On Wed, 2008-08-27 at 00:07 +0200, Sebastian Siewior wrote:
> as of current HEAD "make CROSS=whatever-" breaks once we leave
> the main Makefile.
> With this patch everything builds except NTARGETS in ubi-utils and with
> CROSS being undefined.
> 
> The problem with CROSS being undefined could be solved by setting
> BUILDDIR explicit to "native" for instance.
> The NTARGETS thing is a little tricky. The easiest solution would be
> probably to move the NTARGETS targets into its own Makefile.
> 
> Anyway, is this something worth to fix since it is almost a year broken?
> Should the BUILDDIR thing be removed or is it used?
> 
> Signed-off-by: Sebastian Siewior <sebastian@breakpoint.cc>

I'm very bad in Makefile, so I am not sure what is all this BUILDDIR
stuff about. However, your patch breaks build on x86:

[dedekind@gollum mtd-utils]$ make
gcc  -o .././ubi-utils/pfi2bin pfi2bin.o peb.o error.o list.o crc32.o
libubigen.o bootenv.o hashmap.o reader.o pfi.o
make[1]: *** No rule to make target `.././ubi-utils/ubiattach', needed
by `all'.  Stop.
make[1]: Leaving directory `/home/dedekind/git/mtd-utils/ubi-utils'
make: *** [all] Error 2
rm doc_loadbios.o flash_info.o docfdisk.o ftl_check.o rfdformat.o
nandwrite.o mtd_debug.o flash_otp_dump.o nftldump.o flash_lock.o
flash_otp_info.o rfddump.o flash_unlock.o nftl_format.o flashcp.o
flash_erase.o ftl_format.o nandtest.o nanddump.o

Also, please, make sure your patch does not break make install.

Thanks.
 
-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)