public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind@infradead.org>
To: Tommi Airikka <tommi.airikka@ericsson.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] [MTD-UTILS] nandwrite: read from stdin support
Date: Tue, 02 Sep 2008 13:54:29 +0300	[thread overview]
Message-ID: <1220352869.4036.34.camel@sauron> (raw)
In-Reply-To: <816E1A2C67CC2B488292E7A0981FFD7702AC16FB@esealmw110.eemea.ericsson.se>


On Tue, 2008-09-02 at 11:04 +0200, Tommi Airikka wrote:
> Here is a patch that adds read from stdin support for nandwrite.
> I have tried it with 'cat filename.jffs2 | nandwrite -i filesize -p
> /dev/mtdX -'
> and it did work.

Looks OK for me, but I would rather call stdin "Standard input", not
"Standard in", as you call it in the help output and in the comments.

Also, it would be better to send the patch in-line, not as an
attachment.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

  reply	other threads:[~2008-09-02 10:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-02  9:04 [PATCH] [MTD-UTILS] nandwrite: read from stdin support Tommi Airikka
2008-09-02 10:54 ` Artem Bityutskiy [this message]
2008-09-02 16:21 ` Grant Erickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1220352869.4036.34.camel@sauron \
    --to=dedekind@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=tommi.airikka@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox