From: Artem Bityutskiy <dedekind@infradead.org>
To: Julien Brunel <brunel@diku.dk>
Cc: linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org,
haver@vnet.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/mtd/ubi: Bad IS_ERR test
Date: Fri, 26 Sep 2008 17:48:48 +0300 [thread overview]
Message-ID: <1222440528.5012.19.camel@sauron> (raw)
In-Reply-To: <200809261527.26007.brunel@diku.dk>
On Fri, 2008-09-26 at 15:27 +0200, Julien Brunel wrote:
> In case of error, the function add_volume returns an ERR pointer. The
> result of IS_ERR, which is supposed to be used in a test as it is, is
> here checked to be less than zero, which seems odd. We suggest to
> replace this test by a simple IS_ERR test.
Pushed to ubi-2.6.git, thank you!
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
prev parent reply other threads:[~2008-09-26 14:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-26 13:27 [PATCH] drivers/mtd/ubi: Bad IS_ERR test Julien Brunel
2008-09-26 14:48 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222440528.5012.19.camel@sauron \
--to=dedekind@infradead.org \
--cc=brunel@diku.dk \
--cc=haver@vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox