From: Artem Bityutskiy <dedekind@infradead.org>
To: Bruce_Leonard@selinc.com
Cc: linux-mtd@lists.infradead.org
Subject: Re: [RFC] Support for > 2Gib MTD
Date: Fri, 10 Oct 2008 15:44:08 +0300 [thread overview]
Message-ID: <1223642648.3395.7.camel@sauron> (raw)
In-Reply-To: <OF9C9CDDAA.CE29A97E-ON882574DD.00672609-882574DD.00675F3E@selinc.com>
On Thu, 2008-10-09 at 11:49 -0700, Bruce_Leonard@selinc.com wrote:
> > Please, add something like
> > uint8_t padding[128]; /* Reserved for future, should be zeroed */
> > to the new data structures.
> >
>
> Is this for future expandibility?
Sure.
> > > To indicate that the new 64 bit interface is to be used
> > > I would introduce a new flag for 'struct mtd_info_user_XX->flags',
> > > something like this:
> > >
> > > #define MTD_LARGE_SIZE 0x4000
> >
> > No need for this. Because you'll change size of data structures and
> > their layout, this is not going to be compatible anyway.
> >
> How then would you indicate to user space that they need to use the new
> 64-bit structures and IOCTLs? How does using another bit in an existing
> 'flags' field of a structure change the size and layout of the structure?
If you have different data structure, you cannot reuse old ioctl. You
have to define a new ioctl for the 64-bit interface. Old code will use
old ioctl which you do not change. New code will use new ioctl. Once we
have new ioctls, the old one may be declared as obsolete. This is my
understanding of how things go.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
prev parent reply other threads:[~2008-10-10 12:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 20:36 [RFC] Support for > 2Gib MTD Bruce_Leonard
2008-10-06 5:24 ` Artem Bityutskiy
2008-10-06 6:28 ` Adrian Hunter
2008-10-06 9:02 ` Amit Kumar Sharma
2008-10-06 10:55 ` Artem Bityutskiy
2008-10-09 18:49 ` Bruce_Leonard
2008-10-10 12:44 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1223642648.3395.7.camel@sauron \
--to=dedekind@infradead.org \
--cc=Bruce_Leonard@selinc.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox