From: David Woodhouse <dwmw2@infradead.org>
To: Richard Genoud <richard.genoud@gmail.com>
Cc: linux-mtd <linux-mtd@lists.infradead.org>,
Haavard Skinnemoen <hskinnemoen@atmel.com>
Subject: Re: [PATCH] Bug on atmel_nand HW ECC : OOB info not correctly written
Date: Mon, 13 Oct 2008 15:01:01 +0100 [thread overview]
Message-ID: <1223906461.6770.604.camel@macbook.infradead.org> (raw)
In-Reply-To: <1223793748.7110.13.camel@ubuntu>
On Sun, 2008-10-12 at 08:42 +0200, Richard Genoud wrote:
> The functions that write the OOB info (on hardware ECC only) use the
> HW_SYNDROME method.
> This is not correct : the start position is "pos = eccsize + chunk"
> and should be eccsize.
> So, the standard (nand_write_oob_std) function should be used.
> This patch corrects this by using NAND_ECC_HW instead of
> NAND_ECC_HW_SYNDROME.
>
> This has only been tested on small pages nand flash.
> (if anyone can test it on large pages that would be great).
>
> kernel version : 2.6.27-rc2 (current git mtd-2.6)
>
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Håvard?
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2008-10-13 14:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-12 6:42 [PATCH] Bug on atmel_nand HW ECC : OOB info not correctly written Richard Genoud
2008-10-13 14:01 ` David Woodhouse [this message]
2008-10-13 14:13 ` Haavard Skinnemoen
2008-10-13 15:44 ` Richard Genoud
2008-11-21 9:50 ` Richard Genoud
2008-12-18 12:29 ` Haavard Skinnemoen
2008-12-18 14:03 ` Re : " Richard Genoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1223906461.6770.604.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=hskinnemoen@atmel.com \
--cc=linux-mtd@lists.infradead.org \
--cc=richard.genoud@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox