From: David Woodhouse <dwmw2@infradead.org>
To: Alexey Korolev <akorolev@infradead.org>
Cc: nico@cam.org, linux-mtd@lists.infradead.org
Subject: Re: [RFC/PATCH 4/8] LPDDR QINFO records definitions
Date: Tue, 14 Oct 2008 11:14:13 +0100 [thread overview]
Message-ID: <1223979253.6770.765.camel@macbook.infradead.org> (raw)
In-Reply-To: <alpine.LFD.1.10.0810082227360.13328@casper.infradead.org>
On Wed, 2008-10-08 at 22:29 +0100, Alexey Korolev wrote:
>
> --- /dev/null
> +++ b/include/linux/mtd/qinfo.h
> @@ -0,0 +1,91 @@
> +#include <linux/mtd/map.h>
> +#include <linux/wait.h>
> +#include <linux/spinlock.h>
> +#include <linux/delay.h>
> +#include <linux/mtd/mtd.h>
> +#include <linux/mtd/flashchip.h>
> +#include <linux/mtd/partitions.h>
> +
> +#ifndef __LINUX_MTD_QINFO_H
> +#define __LINUX_MTD_QINFO_H
GCC does magic optimisations to avoid looking at include files for a
second time -- but only if your include guard is around the _whole_
file, iirc. So it's best to move those #includes down below the
#ifndef __LINUX_MTD_QINFO_H
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2008-10-14 10:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 21:29 [RFC/PATCH 4/8] LPDDR QINFO records definitions Alexey Korolev
2008-10-14 10:14 ` David Woodhouse [this message]
2008-10-14 13:03 ` Alexey Korolev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1223979253.6770.765.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=akorolev@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox